Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrate and restore types to ShootOperations #85

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Add migrate and restore types to ShootOperations #85

merged 1 commit into from
Feb 27, 2023

Conversation

SimonKienzler
Copy link
Contributor

What this PR does / why we need it:

For shoot migrations at a larger scale, it is important to have some metrics regarding their state. Therefore, it would be helpful to have not only the states Create, Reconcile and Delete as operation labels, but also Migrate and Restore. This is e.g. used for the metric garden_shoot_operation_states.

Which issue(s) this PR fixes:
n/a

Special notes for your reviewer:
n/a

Release note:

The shoot operation states `Migrate` and `Restore` are now reported as well.

cc @timebertt

@SimonKienzler SimonKienzler requested a review from a team as a code owner February 20, 2023 09:48
@gardener-robot
Copy link

@SimonKienzler Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 20, 2023
@gardener-robot-ci-1
Copy link
Contributor

Thank you @SimonKienzler for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

Copy link
Member

@istvanballok istvanballok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 27, 2023
@istvanballok istvanballok merged commit ba3b43f into gardener:master Feb 27, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 27, 2023
@SimonKienzler SimonKienzler deleted the feature/record-migrate-reconcile branch February 28, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants