Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With ci gosec linter #15

Merged
merged 4 commits into from
Nov 5, 2024
Merged

With ci gosec linter #15

merged 4 commits into from
Nov 5, 2024

Conversation

nickytd
Copy link
Collaborator

@nickytd nickytd commented Nov 5, 2024

This PR add gosec linter check.

Add gosec linter check

@gardener-robot-ci-3
Copy link
Contributor

This PR proposes changes that would break the pipeline definition:

kube-rbac-proxy-watcher-with-ci-gosec-linter: Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/concourse/replicator.py", line 141, in render
    definition_descriptor = self._render(definition_descriptor)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/concourse/replicator.py", line 185, in _render
    'definition': factory.create_pipeline_definition(),
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/concourse/factory.py", line 83, in create_pipeline_definition
    variant = self._create_variant(
              ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/concourse/factory.py", line 138, in _create_variant
    variant._traits_dict = self._create_traits(raw_dict, variant_name)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/concourse/factory.py", line 190, in _create_traits
    name: TraitsFactory.create(
          ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/concourse/model/traits/__init__.py", line 58, in create
    raise ModelValidationError('no such trait: ' + str(name))
model.base.ModelValidationError: no such trait: assets

Signed-off-by: Niki Dokovski <nickytd@gmail.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 5, 2024
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Nov 5, 2024
@nickytd nickytd force-pushed the with-ci-gosec-linter branch from e45a4c9 to 2ba8647 Compare November 5, 2024 12:40
@gardener-robot-ci-2
Copy link
Contributor

The pipeline-definition has been fixed.

@nickytd nickytd marked this pull request as ready for review November 5, 2024 12:41
@nickytd nickytd merged commit ab4ccc1 into main Nov 5, 2024
2 checks passed
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 5, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 5, 2024
@nickytd nickytd deleted the with-ci-gosec-linter branch November 9, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants