Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data disk image reference #155

Closed
wants to merge 15 commits into from
Closed

Conversation

hebelsan
Copy link
Contributor

@hebelsan hebelsan commented Jun 13, 2024

What this PR does / why we need it:
Adds the ability to attach dataDisks with image references

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
It's not possible to create a dataDisk with imageReference afaik.
Therefore we create a general Disk with the imageReference before creating the VM.

Release note:

Adds the ability to attach dataDisks with image references

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jun 13, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 13, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 13, 2024
@hebelsan hebelsan closed this Aug 1, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 1, 2024
@hebelsan
Copy link
Contributor Author

hebelsan commented Aug 1, 2024

closed in favour of #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants