Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove disk type validation #108

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

kon-angelo
Copy link
Contributor

What this PR does / why we need it:
Removes strict disk type validation. The main reason is to support gardener/gardener-extension-provider-gcp#702. As providers add more disk types the validations need to be adapted.

The PR could go either way, of adding the check for the new type or removing the current check and I was in favor of the later approach.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Remove strict validation about disk types

@kon-angelo kon-angelo requested review from a team as code owners February 22, 2024 10:09
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 22, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 22, 2024
@rishabh-11
Copy link
Contributor

If we remove the validation and the disk type does not exist, it will be known only during the VM creation and not before that. Is that fine for the customer?

@kon-angelo
Copy link
Contributor Author

From gardener perspective there is an additional validation done from cloudprofile. So the user will discover it about the same time. But by removing this validation, next time I need to add a disk type, I only need to do it on cloudprofile level.

For a standalone MCM use, the question is if these disks are different than say vm types, which we accept as input, but do not validate against.

Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I think in the standalone case, it should be fine if we don't have the validation, the machine creation call will error out and that should be sufficient

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 8, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 8, 2024
@rishabh-11 rishabh-11 merged commit 9c16c6a into gardener:master Mar 8, 2024
7 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 8, 2024
@kon-angelo kon-angelo deleted the remove-disk-type-validation branch March 8, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants