Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendor directory #112

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Remove vendor directory #112

merged 2 commits into from
Apr 16, 2024

Conversation

rishabh-11
Copy link
Contributor

What this PR does / why we need it:
This PR gets rid of vendor directory in favour of go modules

Which issue(s) this PR fixes:
Fixes part of gardener/machine-controller-manager#902

Special notes for your reviewer:

Release note:

Removed vendor directory

@rishabh-11 rishabh-11 requested review from a team as code owners March 29, 2024 07:13
@rishabh-11 rishabh-11 self-assigned this Mar 29, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 29, 2024
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Mar 29, 2024
AndreasBurger
AndreasBurger approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AndreasBurger AndreasBurger merged commit ca8e682 into gardener:master Apr 16, 2024
7 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 16, 2024
@rishabh-11 rishabh-11 mentioned this pull request May 8, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees

@rishabh-11 rishabh-11

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishabh-11 @AndreasBurger @gardener-robot-ci-1 @gardener-robot