Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix provider spec validation for Driver calls #123

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix provider spec validation for Driver calls #123

merged 2 commits into from
Jun 13, 2024

Conversation

rishabh-11
Copy link
Contributor

@rishabh-11 rishabh-11 commented May 21, 2024 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #114

Special notes for your reviewer:

Release note:

The providerSpec validation has changed for the following driver calls:-
- DeleteMachine, ListMachines, and GetMachineStatus validate only the zone field in the providerSpec.

@rishabh-11 rishabh-11 requested review from a team as code owners May 21, 2024 06:45
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 21, 2024
@rishabh-11 rishabh-11 mentioned this pull request May 21, 2024
Closed
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 21, 2024
unmarshall
unmarshall requested changes Jun 12, 2024
View reviewed changes
pkg/gcp/machine_controller.go Outdated Show resolved Hide resolved
pkg/gcp/validation/validation.go Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jun 12, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 13, 2024
unmarshall
unmarshall approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Jun 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 13, 2024
@unmarshall
Copy link
Contributor

Unfortunately there are no unit tests for validation.go

@rishabh-11
Copy link
Contributor Author

Unfortunately there are no unit tests for validation.go

They are covered in pkg/gcp/machine_controller_test.go but they are very badly written as discussed.

@rishabh-11 rishabh-11 merged commit 45d934c into gardener:master Jun 13, 2024
7 checks passed
@rishabh-11 rishabh-11 deleted the fix-validation branch June 13, 2024 09:06
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

Assignees

@unmarshall unmarshall

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relax disk size validation in MCM GCP to un-block Machine Deletion
5 participants
@rishabh-11 @unmarshall @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot