Skip to content

Commit

Permalink
Added Architecture in NodeTemplate (#894)
Browse files Browse the repository at this point in the history
* Added arch

* Added arch to nodetemplate

* Addressed review comments
  • Loading branch information
sssash18 authored Jan 23, 2024
1 parent c73105b commit 357c319
Show file tree
Hide file tree
Showing 8 changed files with 153 additions and 109 deletions.
232 changes: 123 additions & 109 deletions docs/documents/apis.md

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions kubernetes/crds/machine.sapcloud.io_machineclasses.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ spec:
description: NodeTemplate contains subfields to track all node resources
and other node info required to scale nodegroup from zero
properties:
architecture:
description: CPU Architecture of the node belonging to nodeGroup
type: string
capacity:
additionalProperties:
anyOf:
Expand Down
4 changes: 4 additions & 0 deletions pkg/apis/machine/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -679,4 +679,8 @@ type NodeTemplate struct {

// Zone of the node belonging to nodeGroup
Zone string

// +optional
// CPU Architecture of the node belonging to nodeGroup
Architecture *string
}
4 changes: 4 additions & 0 deletions pkg/apis/machine/v1alpha1/machineclass_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,8 @@ type NodeTemplate struct {

// Zone of the expected node belonging to nodeGroup
Zone string `json:"zone"`

// +optional
// CPU Architecture of the node belonging to nodeGroup
Architecture *string `json:"architecture,omitempty"`
}
2 changes: 2 additions & 0 deletions pkg/apis/machine/v1alpha1/zz_generated.conversion.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions pkg/apis/machine/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions pkg/apis/machine/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions pkg/openapi/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 357c319

Please sign in to comment.