Addressed review comments

gardener · Jan 22, 2024 · 746ecb6 · 746ecb6
1 parent 96afff6
commit 746ecb6
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 17 deletions.
diff --git a/docs/documents/apis.md b/docs/documents/apis.md
@@ -2352,7 +2352,7 @@ string
 </tr>
 <tr>
 <td>
-<code>architecture</code>
+<code>cpuArchitecture</code>
 </td>
 <td>
 <em>
@@ -2361,7 +2361,7 @@ string
 </td>
 <td>
 <em>(Optional)</em>
-<p>Architecture of the node belonging to nodeGroup</p>
+<p>CPU Architecture of the node belonging to nodeGroup</p>
 </td>
 </tr>
 </tbody>

diff --git a/kubernetes/crds/machine.sapcloud.io_machineclasses.yaml b/kubernetes/crds/machine.sapcloud.io_machineclasses.yaml
@@ -55,9 +55,6 @@ spec:
             description: NodeTemplate contains subfields to track all node resources
               and other node info required to scale nodegroup from zero
             properties:
-              architecture:
-                description: Architecture of the node belonging to nodeGroup
-                type: string
               capacity:
                 additionalProperties:
                   anyOf:
@@ -68,6 +65,9 @@ spec:
                 description: Capacity contains subfields to track all node resources
                   required to scale nodegroup from zero
                 type: object
+              cpuArchitecture:
+                description: CPU Architecture of the node belonging to nodeGroup
+                type: string
               instanceType:
                 description: Instance type of the node belonging to nodeGroup
                 type: string

diff --git a/pkg/apis/machine/types.go b/pkg/apis/machine/types.go
@@ -681,6 +681,6 @@ type NodeTemplate struct {
 	Zone string
 
 	// +optional
-	// Architecture of the node belonging to nodeGroup
-	Architecture *string
+	// CPU Architecture of the node belonging to nodeGroup
+	CpuArchitecture *string
 }
diff --git a/pkg/apis/machine/v1alpha1/machineclass_types.go b/pkg/apis/machine/v1alpha1/machineclass_types.go
@@ -86,6 +86,6 @@ type NodeTemplate struct {
 	Zone string `json:"zone"`
 
 	// +optional
-	// Architecture of the node belonging to nodeGroup
-	Architecture *string `json:"architecture,omitempty"`
+	// CPU Architecture of the node belonging to nodeGroup
+	CpuArchitecture *string `json:"cpuArchitecture,omitempty"`
 }
diff --git a/pkg/apis/machine/v1alpha1/zz_generated.conversion.go b/pkg/apis/machine/v1alpha1/zz_generated.conversion.go
diff --git a/pkg/apis/machine/v1alpha1/zz_generated.deepcopy.go b/pkg/apis/machine/v1alpha1/zz_generated.deepcopy.go
diff --git a/pkg/apis/machine/zz_generated.deepcopy.go b/pkg/apis/machine/zz_generated.deepcopy.go
diff --git a/pkg/openapi/openapi_generated.go b/pkg/openapi/openapi_generated.go