Apply suggestions from code review

Co-authored-by: Amshuman K R <amshuman.rao.karaya@sap.com>
gardener · May 12, 2020 · 793b105 · 793b105
1 parent d86c027
commit 793b105
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/pkg/controller/machine_util.go b/pkg/controller/machine_util.go
@@ -257,7 +257,7 @@ func (c *controller) validateMachineClass(classSpec *v1alpha1.ClassSpec) (interf
 			return MachineClass, secretRef, err
 		}
 	default:
-		klog.V(2).Infof("ClassKind %q not found", classSpec.Kind)
+		klog.V(4).Infof("ClassKind %q not found. Machine maybe be processed by external controller", classSpec.Kind)
 	}
 
 	return MachineClass, secretRef, nil

diff --git a/pkg/util/provider/machinecontroller/controller.go b/pkg/util/provider/machinecontroller/controller.go
@@ -240,7 +240,7 @@ func (c *controller) Run(workers int, stopCh <-chan struct{}) {
 	prometheus.MustRegister(c)
 
 	for i := 0; i < workers; i++ {
-		createWorker(c.machineClassQueue, "ClustermachineClass", maxRetries, true, c.reconcileClustermachineClassKey, stopCh, &waitGroup)
+		createWorker(c.machineClassQueue, "ClusterMachineClass", maxRetries, true, c.reconcileClusterMachineClassKey, stopCh, &waitGroup)
 		createWorker(c.nodeQueue, "ClusterNode", maxRetries, true, c.reconcileClusterNodeKey, stopCh, &waitGroup)
 		createWorker(c.machineQueue, "ClusterMachine", maxRetries, true, c.reconcileClusterMachineKey, stopCh, &waitGroup)
 		createWorker(c.machineSafetyOrphanVMsQueue, "ClusterMachineSafetyOrphanVMs", maxRetries, true, c.reconcileClusterMachineSafetyOrphanVMs, stopCh, &waitGroup)

diff --git a/pkg/util/provider/machinecontroller/machineclass.go b/pkg/util/provider/machinecontroller/machineclass.go
@@ -86,9 +86,9 @@ func (c *controller) machineClassUpdate(oldObj, newObj interface{}) {
 	c.machineClassAdd(newObj)
 }
 
-// reconcileClustermachineClassKey reconciles an machineClass due to controller resync
+// reconcileClusterMachineClassKey reconciles an machineClass due to controller resync
 // or an event on the machineClass.
-func (c *controller) reconcileClustermachineClassKey(key string) error {
+func (c *controller) reconcileClusterMachineClassKey(key string) error {
 	_, name, err := cache.SplitMetaNamespaceKey(key)
 	if err != nil {
 		return err
@@ -104,10 +104,10 @@ func (c *controller) reconcileClustermachineClassKey(key string) error {
 		return err
 	}
 
-	return c.reconcileClustermachineClass(class)
+	return c.reconcileClusterMachineClass(class)
 }
 
-func (c *controller) reconcileClustermachineClass(class *v1alpha1.MachineClass) error {
+func (c *controller) reconcileClusterMachineClass(class *v1alpha1.MachineClass) error {
 	klog.V(4).Info("Start Reconciling machineclass: ", class.Name)
 	defer func() {
 		c.enqueueMachineClassAfter(class, 10*time.Minute)