Add "auth-extra-groups" field to bootstrap token #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
hardikdr
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
|
I am generally fine either way. Setting it per machine-class secret could be useful to differentiate the auth-groups per machine-classes as well. |
|
I'd like to leave as it is. It serves us perfectly since we are using MCM without Gardener (for now). If a need arises, it can easily be refactored. |
hardikdr
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
hardikdr
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I'd like to access Kubernetes objects in some way or another using the bootstrap token. It's possible to do just that by providing the
auth-extra-groupsfield (this PR) and creating a Role/RoleBinding.Special notes for your reviewer:
The format of the configuration is open to discussion. Perhaps, it would be better to move this to a per-MachineClass Secret?
Release note: