-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openstack] Config drive option #457
[openstack] Config drive option #457
Conversation
Thanks for the PR @zuzzas. |
@afritzler @kayrus @dguendisch Would be really nice if you could take a brief look if possible :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about still having an explicit and optional switch in the machineclass to enable config drive support? I like auto detect method - however having an explicit way to configure it would be also nice.
One other reason for explicit support in the |
dc76d79
to
d400e0e
Compare
@afritzler |
"github.com/gardener/machine-controller-manager/pkg/apis/machine/v1alpha1" | ||
"github.com/gardener/machine-controller-manager/pkg/metrics" | ||
"github.com/gophercloud/gophercloud/openstack/networking/v2/networks" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done by goimports
.
@afritzler It Would be nice if you could take a look again. |
There seems to be a minor file-conflict, can you please take a look @zuzzas . |
Signed-off-by: Andrey Klimentyev <andrey.klimentyev@flant.com>
d400e0e
to
ec82f8b
Compare
@hardikdr, it is done. |
@kayrus @afritzler I would be nice if you could take a look and approve if possible :) |
Let me test that against our environment and get back to you by Monday. Pretty swamped atm. |
Hi @afritzler , Did you get a chance to test these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@zuzzas Can use adjust the PR description to reflect the latest state? There is still described that automatic detection is used, but it's not in the code anymore. |
Ok, I finally also came around to test this PR. Creating machines without and with config drive support
in the /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Done. |
Thanks, everyone. I will go ahead merging then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Add an option to use config drive while provisioning OpenStack Servers.
Release note: