Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow deletion of VM even on image/instance get failures. #520

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Allow deletion of VM even on image/instance get failures. #520

merged 1 commit into from
Sep 23, 2020

Conversation

prashanth26
Copy link
Contributor

@prashanth26 prashanth26 commented Sep 23, 2020 •
edited
Loading

What this PR does / why we need it:
Allow deletion of VM even on image/instance get failures.

Which issue(s) this PR fixes:
Fixes #520

Special notes for your reviewer:

Release note:

Allow deletion of VM even on image/instance get failures.

@prashanth26 prashanth26 requested review from ggaurav10 and a team as code owners September 23, 2020 11:35
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 23, 2020
hardikdr
hardikdr approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Sep 23, 2020
@prashanth26
Copy link
Contributor Author

/ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 23, 2020
@prashanth26 prashanth26 merged commit 26c870c into gardener:rel-v0.33.0 Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr hardikdr approved these changes

@ggaurav10 ggaurav10 Awaiting requested review from ggaurav10

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prashanth26 @hardikdr @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot