Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce backoff while enqueuing machine objects on creatio… #527

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Introduce backoff while enqueuing machine objects on creatio… #527

merged 1 commit into from
Oct 6, 2020

Conversation

prashanth26
Copy link
Contributor

@prashanth26 prashanth26 commented Oct 6, 2020 •
edited
Loading

…n and deletion failures

Co-authored-by: hardikdr hardik.dodiya@sap.com

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Porting fix from master onto rel-v0.33.0

Release note:

Introduced a backoff in re-enqueuing machines on creation/deletion failures. Avoids throttling APIServer & provider calls.

Adds a new phase `CrashLoopBackOff` that is set due to machine creation failures.

@hardikdr @prashanth26
Introduce constant backoff while enqueuing machine objects on creatio…
ca0626e 
…n and deletion failures

Co-authored-by: Prashanth <prashanth@sap.com>
@prashanth26 prashanth26 requested review from ggaurav10 and a team as code owners October 6, 2020 08:14
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 6, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 6, 2020
hardikdr
hardikdr approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Oct 6, 2020
@prashanth26 prashanth26 merged commit c120774 into gardener:rel-v0.33.0 Oct 6, 2020
@prashanth26 prashanth26 changed the title Introduce constant backoff while enqueuing machine objects on creatio… Introduce backoff while enqueuing machine objects on creatio… Oct 6, 2020
This was referenced Nov 6, 2020
Open
Closed
Closed
@prashanth26 prashanth26 deleted the rel-v0.33.0 branch May 2, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr hardikdr approved these changes

@ggaurav10 ggaurav10 Awaiting requested review from ggaurav10

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prashanth26 @hardikdr @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot