-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Fixed issues with machineClass finalizers #531
Merged
prashanth26
merged 3 commits into
gardener:master
from
prashanth26:bugfix/finalizers-addition
Oct 15, 2020
Merged
Bugfix: Fixed issues with machineClass finalizers #531
prashanth26
merged 3 commits into
gardener:master
from
prashanth26:bugfix/finalizers-addition
Oct 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
Needs review
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
labels
Oct 14, 2020
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 14, 2020
gardener-robot-ci-2
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 14, 2020
prashanth26
force-pushed
the
bugfix/finalizers-addition
branch
from
October 14, 2020 10:23
073020d
to
ce21198
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 14, 2020
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 14, 2020
hardikdr
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the PR.
/lgtm
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
labels
Oct 14, 2020
ggaurav10
reviewed
Oct 14, 2020
prashanth26
force-pushed
the
bugfix/finalizers-addition
branch
from
October 14, 2020 15:03
ce21198
to
489a41b
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 14, 2020
Fixed minor typo
prashanth26
force-pushed
the
bugfix/finalizers-addition
branch
from
October 14, 2020 15:04
489a41b
to
db00966
Compare
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 14, 2020
/ok-to-test |
prashanth26
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 14, 2020
gardener-robot-ci-2
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Oct 14, 2020
prashanth26
changed the title
Bugfix/finalizers addition
Bugfix: Fixed issues with machineClass finalizers
Oct 14, 2020
gardener-robot
added
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
needs/second-opinion
Needs second review by someone else
and removed
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
reviewed/lgtm
Has approval for merging
labels
Oct 15, 2020
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 15, 2020
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 15, 2020
prashanth26
force-pushed
the
bugfix/finalizers-addition
branch
from
October 15, 2020 05:32
91db3ff
to
e6ce7d3
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 15, 2020
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Oct 15, 2020
ggaurav10
approved these changes
Oct 15, 2020
hardikdr
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/second-opinion
Needs second review by someone else
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Without proper finalizers, machine classes backing machines were lost on deletions.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This partially reverts this change - 0a56891#diff-a327d9bce2e5949213510b45b329fa9d45d2dedfcce11e407e51e876549f265bL130-L137
Release note: