Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick PR#575 into MCM rel-v0.35 #577

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Cherrypick PR#575 into MCM rel-v0.35 #577

merged 1 commit into from
Nov 26, 2020

Conversation

AxiomSamarth
Copy link
Contributor

@AxiomSamarth AxiomSamarth commented Nov 26, 2020

Signed-off-by: ialidzhikov i.alidjikov@gmail.com

What this PR does / why we need it:
#500 introduces a change that takes only the first 5 elements of the encoded machine template hash. This actually panics when the endoded machine template hash length is less than 5

Which issue(s) this PR fixes:
Fixes #461
Hotfix for a bug introduced by #500

Special notes for your reviewer:

Release note:

An issue causing panic when the encoded machine template hash length is less than expect limit is now fixed.

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@AxiomSamarth AxiomSamarth requested review from ggaurav10 and a team as code owners November 26, 2020 16:44
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 26, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 26, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 26, 2020
@AxiomSamarth AxiomSamarth changed the title Prevent panic when machine template hash length is < 5 Cherry-picking PR#575 into MCM rel-v0.35 Nov 26, 2020
@prashanth26 prashanth26 changed the title Cherry-picking PR#575 into MCM rel-v0.35 Cherrypick PR#575 into MCM rel-v0.35 Nov 26, 2020
Copy link
Contributor

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants