-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for misconfigured PDBs on Node drain and set proper error description #591
Conversation
…iption Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this change @ialidzhikov . A very meaningful change.
Minor comment: This change is only on the OOT branch of MCM and this change wouldn't be backward compatible with any controllers (example: extension-provider-azure or other external controllers using in-tree) currently using in-tree MCM. This is fine as we anyways would deprecate the in-tree MCM code eventually move to OOT code, just wanted to mention/remind you.
Changes /lgtm otherwise
- apiGroups: | ||
- policy | ||
resources: | ||
- poddisruptionbudgets | ||
verbs: | ||
- watch | ||
- list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder: We will have to update all the extensions to adapt the cluster-roles to add this post merging of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sure, I have in mind to update the RBAC of the gardener provider extensions when we update the corresponding MCM provider version in the extension that vendors this PR. For the gardener provider extensions that still use in-tree MCM, there is no action required. |
Sure sound good. We will also need to vendor the library into the MCM OOT providers and then make releases for this change to kick in. Which is fine for now. So i shall go ahead and merge this? |
Yep.
If it also looks good to you, then we can proceed with it. |
/area ops-productivity
/kind enhancement
Currently the Machine status does not clearly indicate pod eviction failures that are caused by misconfigured PodDisruptionBudgets.
With this PR the Machine
.status.lastOperation.description
clearly indicates for misconfigured PodDisruptionBudgets:This will allow components like extension controllers to match
.status.lastOperation.description
and to properly flag it as configuration problem - ref gardener/gardener#3020.Which issue(s) this PR fixes:
Needed for gardener/gardener#3020
Release note: