Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using controller-gen latest version for crd generation #640

Merged
merged 2 commits into from
Aug 20, 2021
Merged

using controller-gen latest version for crd generation #640

merged 2 commits into from
Aug 20, 2021

Conversation

himanshu-kun
Copy link
Contributor

What this PR does / why we need it:
This PR updates the version of controller-gen in MakeFile , which is used to generate crd.
With use of this , now we can generate v1 version of CRD using the rule make generate. Earlier v1beta1 was getting generated.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`make generate` now generates v1 version of CRDs by default instead of v1beta1.

@himanshu-kun himanshu-kun requested a review from a team as a code owner August 19, 2021 05:18
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 19, 2021
@AxiomSamarth
Copy link
Contributor

I am thinking if it would be a good idea to already generate one set of v1 CRDs & merge them via this PR. @prashanth26 WDYT?

@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 19, 2021
@himanshu-kun
Copy link
Contributor Author

I am thinking if it would be a good idea to already generate one set of v1 CRDs & merge them via this PR. @prashanth26 WDYT?

Done, thanks

AxiomSamarth
AxiomSamarth approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@AxiomSamarth AxiomSamarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Aug 19, 2021
prashanth26
prashanth26 approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@prashanth26 prashanth26 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change. Do we need to revendor? I suppose not?
/lgtm

@AxiomSamarth
Copy link
Contributor

AxiomSamarth commented Aug 19, 2021 •
edited
Loading

Thanks for this change. Do we need to revendor? I suppose not?
/lgtm

I guess not, @prashanth26. Not in the out of tree. However, I think there are some places in the integration test package where the API call changes has to be done from v1beta1 to v1 & I think @himanshu-kun has already made the changes & he will push in the other PR on IT improvements. @himanshu-kun Could you please confirm?

@himanshu-kun
Copy link
Contributor Author

Thanks for this change. Do we need to revendor? I suppose not?
/lgtm

I guess not, @prashanth26. Not in the out of tree. However, I think there are some places in the integration test package where the API call changes has to be done from v1beta1 to v1 & I think @himanshu-kun has already made the changes & he will push in the other PR on IT improvements. @himanshu-kun Could you please confirm?

yes I have made those changes and pushed them on the IT improvements PR. This commit has the changes

@prashanth26
Copy link
Contributor

Thanks for this change. Do we need to revendor? I suppose not?
/lgtm

I guess not, @prashanth26. Not in the out of tree. However, I think there are some places in the integration test package where the API call changes has to be done from v1beta1 to v1 & I think @himanshu-kun has already made the changes & he will push in the other PR on IT improvements. @himanshu-kun Could you please confirm?

yes I have made those changes and pushed them on the IT improvements PR. This commit has the changes

Thank you. We can merge it then I think.

@prashanth26 prashanth26 merged commit e096125 into gardener:master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AxiomSamarth AxiomSamarth AxiomSamarth approved these changes

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees
No one assigned
Labels
reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@himanshu-kun @AxiomSamarth @prashanth26 @gardener-robot