-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using controller-gen latest version for crd generation #640
Conversation
I am thinking if it would be a good idea to already generate one set of v1 CRDs & merge them via this PR. @prashanth26 WDYT? |
Done, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change. Do we need to revendor? I suppose not?
/lgtm
I guess not, @prashanth26. Not in the out of tree. However, I think there are some places in the integration test package where the API call changes has to be done from |
yes I have made those changes and pushed them on the IT improvements PR. This commit has the changes |
Thank you. We can merge it then I think. |
What this PR does / why we need it:
This PR updates the version of
controller-gen
in MakeFile , which is used to generate crd.With use of this , now we can generate v1 version of CRD using the rule
make generate
. Earlier v1beta1 was getting generated.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: