Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRD manifests #641

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Fix CRD manifests #641

merged 2 commits into from
Aug 25, 2021

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Aug 24, 2021

What this PR does / why we need it:
This PR fixes the CRD manifests for several objects that use metav1.ObjectMeta or runtime.RawExtension. It's necessary to set x-kubernetes-preserve-unknown-fields: true for these types because otherwise data underneath related fields is pruned and leads to validation errors in MCM.

Example:

I0824 09:05:30.777736       1 machine_controller_util.go:366] List machines failed on decodeProviderSpecAndSecret: machine codes error: code = [Internal] message = [Error while validating ProviderSpec [spec.disks: Required value: at least one disk is required spec.machineType: Required value: machineType is required spec.region: Required value: region is required spec.zone: Required value: zone is required spec.networkInterfaces.networkInterfaces: Required value: at least one network interface is required spec.scheduling.onHostMaintenance: Unsupported value: "": supported values: "MIGRATE", "TERMINATE" spec.serviceAccounts: Required value: at least one service account is required]]
# Please edit the object below. Lines beginning with a '#' will be ignored,

I added additional printer columns for Machines that we already use in Gardener along the way (4bb8db0).

Release note:

A bug has been fixed in the pre-delivered CRD manifests for MCM (`/kubernetes/crds`). It caused data to be pruned from MCM related resources and led to reconciliation issues.

@timuthy timuthy requested a review from a team as a code owner August 24, 2021 13:18
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 24, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 24, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 24, 2021
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 24, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 24, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 24, 2021
Copy link
Contributor

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @timuthy . Love it <3

/invite @AxiomSamarth

@prashanth26 prashanth26 merged commit 611e0a4 into gardener:master Aug 25, 2021
@timuthy timuthy deleted the fix/crd branch August 25, 2021 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants