Trigger orphan collection on OutOfRange machine status #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
the
size/m
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
himanshu-kun
force-pushed
the
eventual_consistency_handle
branch
from
5548f1e
to
01b31ee
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
@dkistner could you provide you review as well:) |
|
Merging as a new release is awaited by Core colleagues |
|
@AxiomSamarth could you provide you approving review and merge? |
dkistner
reviewed
Jan 11, 2022
There was a problem hiding this comment.
Hi @himanshu-kun,
sorry for the delay. From my point of view this looks good.
But I would really like to have @AxiomSamarth opinion also on this.
gardener-robot
added
reviewed/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Till now orphan collection triggers on machine obj deletion or after 30min.
But to handle cases which arise due to eventual inconsistency in AWS , where multiple VMs can start backing a machine obj, in that case to stop machine-controller to reach the VM quota , orphan collection is now also triggered if machine object is updated with a
OutOfRangeerror description.The update of machine obj to
OutOfRangecan only happen byGetMachineStatuscall , which is called only during a machine creation or deletion.So in summary , orphan collection will be triggered in three cases now
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I haven't enqueued in the orphan queue if status contains OOR error now , but only if the machine obj status
earlier didn't haveOOR error and now have it.This is to deal with scenario where machine obj has OOR error already and any other status update event triggers. So if we enqueue just on presence of OOR error ,then orphan logic will be triggered almost all the time
Release note: