Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale down annotation value corrected #685

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Scale down annotation value corrected #685

merged 1 commit into from
Mar 3, 2022

Conversation

himanshu-kun
Copy link
Contributor

What this PR does / why we need it:
The annotation value of scale down annotation provided by CA has been changed from True to true. This will enable MCM to stop CA from scaling down during rolling update of machines.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The value for key `cluster-autoscaler.kubernetes.io/scale-down-disabled` placed by MCM is now `true` and not `True`. This typo stopped MCM from disabling CA from scaling down during rolling update.

@himanshu-kun himanshu-kun requested a review from a team as a code owner March 3, 2022 10:28
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 3, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 3, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 3, 2022
unmarshall
unmarshall approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 3, 2022
@unmarshall unmarshall merged commit 32b950d into gardener:master Mar 3, 2022
@himanshu-kun himanshu-kun mentioned this pull request Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@himanshu-kun @unmarshall @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot