Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version of clusterroles, add resoureName for leases #738

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Update version of clusterroles, add resoureName for leases #738

merged 1 commit into from
Aug 5, 2022

Conversation

rishabh-11
Copy link
Contributor

@rishabh-11 rishabh-11 commented Aug 5, 2022 •
edited
Loading

What this PR does / why we need it:
This PR updates the rule for leases in cluster role and moves clusterroles/clusterrolebindings to v1 from v1beta1. This is needed for the mcm-provider IT to work when running the controllers inside a cluster and not as a local process.

Which issue(s) this PR fixes:
Fixes #674

Special notes for your reviewer:

Release note:

resourceName `machine-controller` added for leases in clusterrole. Updated version of Clusterroles and Clusterrolebindings to v1.

@rishabh-11 rishabh-11 requested a review from a team as a code owner August 5, 2022 08:52
@gardener-robot
Copy link

@rishabh-11 Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 5, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 5, 2022
himanshu-kun
himanshu-kun approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 5, 2022
@himanshu-kun himanshu-kun merged commit d7e3c5d into gardener:master Aug 5, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 5, 2022
rishabh-11 added a commit to rishabh-11/machine-controller-manager that referenced this pull request Aug 5, 2022
@rishabh-11
update clusterroles and clusterrolebindings to v1 (gardener#738)
88737a7
himanshu-kun pushed a commit that referenced this pull request Aug 5, 2022
@rishabh-11
update clusterroles and clusterrolebindings to v1 (#738) (#739)
959cbe7
@rishabh-11 rishabh-11 deleted the update-roles-to-v1 branch September 23, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update clusterRole for local deployment of MCM and MC
4 participants
@rishabh-11 @gardener-robot @himanshu-kun @gardener-robot-ci-1