Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle PodDisruptionBudget policy/v1 #744

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Handle PodDisruptionBudget policy/v1 #744

merged 3 commits into from
Sep 6, 2022

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Sep 1, 2022 •
edited by himanshu-kun
Loading

What this PR does / why we need it:
The policy/v1beta1 API version of PodDisruptionBudget will no longer be served in v1.25.
We should migrate manifests and API clients to use the policy/v1 API version, available since v1.21

Which issue(s) this PR fixes:
Part of gardener/gardener#6567

Special notes for your reviewer:

Release note:

Migrated clients to use `policy/v1` `PodDisruptionBudget` for kubernetes versions >= 1.21. `policy/v1beta1` PDB is also supported but for k8s < 1.21

@shafeeqes shafeeqes requested a review from a team as a code owner September 1, 2022 03:11
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 1, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 1, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 1, 2022
@shafeeqes shafeeqes mentioned this pull request Sep 1, 2022
Closed
25 tasks
@shafeeqes
Copy link
Contributor Author

/invite @himanshu-kun @rishabh-11

@gardener-robot
Copy link

@rishabh-11, @himanshu-kun You have pull request review open invite, please check

@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 5, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 5, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 5, 2022
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Sep 5, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 5, 2022
@shafeeqes shafeeqes closed this Sep 5, 2022
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged) and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 5, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 5, 2022
@shafeeqes shafeeqes reopened this Sep 5, 2022
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) and removed status/closed Issue is closed (either delivered or triaged) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 5, 2022
@shafeeqes
Copy link
Contributor Author

/squash

@gardener-robot gardener-robot added the merge/squash Should be merged via 'Squash and merge' label Sep 5, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 6, 2022
himanshu-kun
himanshu-kun approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thnx for the changes @shafeeqes

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Sep 6, 2022
@shafeeqes
Copy link
Contributor Author

Thanks for the review, Can we have a release with this PR included?

@himanshu-kun himanshu-kun merged commit 07c8043 into gardener:master Sep 6, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 6, 2022
@himanshu-kun
Copy link
Contributor

I am planning a release by EoD

@shafeeqes shafeeqes deleted the enh/pdb branch September 6, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

@rishabh-11 rishabh-11 Awaiting requested review from rishabh-11

Assignees
No one assigned
Labels
merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shafeeqes @gardener-robot @himanshu-kun @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3