-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle PodDisruptionBudget
policy/v1
#744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
Needs review
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
labels
Sep 1, 2022
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 1, 2022
gardener-robot-ci-3
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Sep 1, 2022
25 tasks
/invite @himanshu-kun @rishabh-11 |
@rishabh-11, @himanshu-kun You have pull request review open invite, please check |
gardener-robot
added
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
needs/second-opinion
Needs second review by someone else
and removed
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
labels
Sep 5, 2022
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 5, 2022
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 5, 2022
gardener-robot
added
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
and removed
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
labels
Sep 5, 2022
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Sep 5, 2022
gardener-robot
added
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
and removed
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
labels
Sep 5, 2022
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 5, 2022
gardener-robot
added
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
and removed
status/closed
Issue is closed (either delivered or triaged)
size/xs
Size of pull request is tiny (see gardener-robot robot/bots/size.py)
labels
Sep 5, 2022
/squash |
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Sep 6, 2022
himanshu-kun
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thnx for the changes @shafeeqes
gardener-robot
added
reviewed/lgtm
Has approval for merging
and removed
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
labels
Sep 6, 2022
Thanks for the review, Can we have a release with this PR included? |
gardener-robot
added
the
status/closed
Issue is closed (either delivered or triaged)
label
Sep 6, 2022
I am planning a release by EoD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merge/squash
Should be merged via 'Squash and merge'
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The policy/v1beta1 API version of PodDisruptionBudget will no longer be served in v1.25.
We should migrate manifests and API clients to use the policy/v1 API version, available since v1.21
Which issue(s) this PR fixes:
Part of gardener/gardener#6567
Special notes for your reviewer:
Release note: