Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add short names for Machine, MachineClass, MachineDeployment and MachineSet resources #747

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Add short names for Machine, MachineClass, MachineDeployment and MachineSet resources #747

merged 1 commit into from
Oct 10, 2022

Conversation

rishabh-11
Copy link
Contributor

@rishabh-11 rishabh-11 commented Oct 10, 2022 •
edited by himanshu-kun
Loading

What this PR does / why we need it:
This PR adds short names for machine, machineclass, machinedeployment and machineset resources. The abbreviations are as follows:

  1. mach -> machines.

Screenshot 2022-10-10 at 10 59 08 AM

2. machcls -> machineclass

Screenshot 2022-10-10 at 10 59 20 AM

3. machdeploy -> machinedeployment

Screenshot 2022-10-10 at 11 04 45 AM

4. machset -> machineset

Screenshot 2022-10-10 at 11 04 52 AM

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
The testing was done by running IT on dev cluster with mcm and mcm-provider-aws run locally.

Release note:

NONE

@rishabh-11 rishabh-11 requested a review from a team as a code owner October 10, 2022 05:53
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Oct 10, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 10, 2022
himanshu-kun
himanshu-kun approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Oct 10, 2022
@himanshu-kun himanshu-kun merged commit 4b26085 into gardener:master Oct 10, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 10, 2022
@rishabh-11 rishabh-11 deleted the short-names-for-resources branch October 10, 2022 07:27
@rishabh-11
Copy link
Contributor Author

Release notes are removed. The final PR for short names has the release notes. It can be checked here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishabh-11 @himanshu-kun @gardener-robot-ci-2 @gardener-robot