Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn CrashloopBackoff machines to Running quicker #806

Merged
merged 6 commits into from
Apr 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions docs/documents/apis.md
Original file line number Diff line number Diff line change
Expand Up @@ -2480,9 +2480,7 @@ Kubernetes core/v1.NodeConfigSource
</td>
<td>
<em>(Optional)</em>
<p>Deprecated. If specified, the source of the node&rsquo;s configuration.
The DynamicKubeletConfig feature gate must be enabled for the Kubelet to use this field.
This field is deprecated as of 1.22: <a href="https://git.k8s.io/enhancements/keps/sig-node/281-dynamic-kubelet-configuration">https://git.k8s.io/enhancements/keps/sig-node/281-dynamic-kubelet-configuration</a></p>
<p>Deprecated: Previously used to specify the source of the node&rsquo;s configuration for the DynamicKubeletConfig feature. This feature is removed.</p>
</td>
</tr>
<tr>
Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/machine/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ const (
// MachineRunning means node is ready and running successfully
MachineRunning MachinePhase = "Running"

// MachineRunning means node is terminating
// MachineTerminating means node is terminating
MachineTerminating MachinePhase = "Terminating"

// MachineUnknown indicates that the node is not ready at the movement
Expand All @@ -220,7 +220,7 @@ const (
// MachineFailed means operation failed leading to machine status failure
MachineFailed MachinePhase = "Failed"

// MachineCrashLoopBackOff means creation or deletion of the machine is failing.
// MachineCrashLoopBackOff means creation or deletion of the machine is failing. It means that machine object is present but there is no corresponding VM.
MachineCrashLoopBackOff MachinePhase = "CrashLoopBackOff"
)

Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/machine/v1alpha1/machine_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ const (
// MachineRunning means node is ready and running successfully
MachineRunning MachinePhase = "Running"

// MachineRunning means node is terminating
// MachineTerminating means node is terminating
MachineTerminating MachinePhase = "Terminating"

// MachineUnknown indicates that the node is not ready at the movement
Expand All @@ -155,7 +155,7 @@ const (
// MachineFailed means operation failed leading to machine status failure
MachineFailed MachinePhase = "Failed"

// MachineCrashLoopBackOff means creation or deletion of the machine is failing.
// MachineCrashLoopBackOff means creation or deletion of the machine is failing. It means that machine object is present but there is no corresponding VM.
MachineCrashLoopBackOff MachinePhase = "CrashLoopBackOff"
)

Expand Down
41 changes: 32 additions & 9 deletions pkg/client/clientset/internalversion/clientset.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

41 changes: 32 additions & 9 deletions pkg/client/clientset/versioned/clientset.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading