Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendoring and improve code generation #885

Closed
wants to merge 2 commits into from
Closed

Remove vendoring and improve code generation #885

wants to merge 2 commits into from

Conversation

afritzler
Copy link
Member

@afritzler afritzler commented Dec 19, 2023 •
edited
Loading

What this PR does / why we need it:

  • Remove vendoring from project
  • Improve tools installation
  • Add new hack/update-codegen.sh which is used for code generation
  • Improve Makefile structure

Special notes for your reviewer:

Release note:

Remove vendoring and improve code generation

@afritzler
Remove vendor folder
ca26667
@afritzler
Adjust code generation and Makefile improvements
05ad709 
- Improve tools installation in Makefile
- Refactor code generation by using new hack/update-codegen.sh script
- Adjust ci scripts to reflect vendor removal
@gardener-robot
Copy link

@afritzler Thank you for your contribution.

@gardener-robot gardener-robot added the needs/review Needs review label Dec 19, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 19, 2023
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Dec 19, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 19, 2023
@afritzler afritzler changed the title Remove vendoring and improve Makefile Remove vendoring and improve code generation Dec 19, 2023
@gardener-robot
Copy link

@afritzler You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jan 24, 2024
@rishabh-11
Copy link
Contributor

/close in favour of #903

@rishabh-11 rishabh-11 closed this Apr 18, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@unmarshall unmarshall

@elankath elankath

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@afritzler @gardener-robot @rishabh-11 @unmarshall @elankath @gardener-robot-ci-2 @gardener-robot-ci-3