Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API doc #927

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix API doc #927

merged 1 commit into from
Jul 10, 2024

Conversation

rishabh-11
Copy link
Contributor

What this PR does / why we need it:
This PR fixes the API spec doc in docs/documents/apis.md

Which issue(s) this PR fixes:
Fixes #918

Special notes for your reviewer:

Release note:

Broken API doc links are now fixed

@rishabh-11 rishabh-11 requested a review from a team as a code owner July 10, 2024 11:09
@gardener-robot gardener-robot added the needs/review Needs review label Jul 10, 2024
@gardener-robot gardener-robot added the size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) label Jul 10, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 10, 2024
@gardener-robot gardener-robot added the needs/second-opinion Needs second review by someone else label Jul 10, 2024
@rishabh-11 rishabh-11 changed the title Fix api docs Fix api doc Jul 10, 2024
@rishabh-11 rishabh-11 changed the title Fix api doc Fix API doc Jul 10, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 10, 2024
elankath
elankath approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@elankath elankath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for linkForType fix.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 10, 2024
@rishabh-11 rishabh-11 added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 10, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 10, 2024
@gardener-robot gardener-robot removed the needs/second-opinion Needs second review by someone else label Jul 10, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 10, 2024
@rishabh-11 rishabh-11 merged commit 21fc93f into gardener:master Jul 10, 2024
8 checks passed
@rishabh-11 rishabh-11 deleted the fix-docs branch July 10, 2024 11:35
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elankath elankath elankath approved these changes

Assignees

@elankath elankath

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Api reference links are broken
5 participants
@rishabh-11 @elankath @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot