Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce gosec for Static Application Security Testing (SAST) #75

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Introduce gosec for Static Application Security Testing (SAST) #75

merged 3 commits into from
Oct 14, 2024

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
This PR introduces gosec for Static Application Security Testing at Gardener and should replace other code scanners.

It uses the default ruleset of gosec from gardener/gardener as introduced in gardener/gardener#9959.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`gosec` was introduced for Static Application Security Testing (SAST).

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 11, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 11, 2024
@MartinWeindel MartinWeindel marked this pull request as ready for review October 14, 2024 07:14
@MartinWeindel MartinWeindel requested a review from a team as a code owner October 14, 2024 07:14
ScheererJ
ScheererJ approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 14, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 14, 2024
@MartinWeindel MartinWeindel merged commit 17f0117 into main Oct 14, 2024
6 checks passed
@MartinWeindel MartinWeindel deleted the introduce-gosec branch October 14, 2024 07:26
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinWeindel @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot