Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support also checks for ipv6 endpoints #76

Merged
merged 1 commit into from
Oct 15, 2024
Merged

support also checks for ipv6 endpoints #76

merged 1 commit into from
Oct 15, 2024

Conversation

DockToFuture
Copy link
Member

@DockToFuture DockToFuture commented Oct 15, 2024 •
edited
Loading

What this PR does / why we need it:
Support tcp checks for ipv6 endpoints.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
After that changes, tests are successfully executed for an ipv6 shoot cluster.

time="2024-10-15T09:04:11Z" level=info msg="Report: SourceHost: ok/unknown/failed: 1/0/1 (failed items: i-0c014b64770a21fe7.eu-west-1.compute.internal)" cmd=agent sub=aggr
time="2024-10-15T09:04:11Z" level=info msg="Report: DestHost: ok/unknown/failed: 5/0/2 (failed items: i-064754bd354e51493.eu-west-1.compute.internal,i-0c014b64770a21fe7.eu-west-1.compute.internal)" cmd=agent sub=aggr
time="2024-10-15T09:05:13Z" level=info msg="Report: Jobs: ok/unknown/failed: 7/0/0" cmd=agent sub=aggr
time="2024-10-15T09:05:13Z" level=info msg="Report: SourceHost: ok/unknown/failed: 1/0/0" cmd=agent sub=aggr
time="2024-10-15T09:05:13Z" level=info msg="Report: DestHost: ok/unknown/failed: 5/0/0" cmd=agent sub=aggr
time="2024-10-15T09:06:14Z" level=info msg="Report: Jobs: ok/unknown/failed: 7/0/0" cmd=agent sub=aggr
time="2024-10-15T09:06:14Z" level=info msg="Report: SourceHost: ok/unknown/failed: 1/0/0" cmd=agent sub=aggr
time="2024-10-15T09:06:14Z" level=info msg="Report: DestHost: ok/unknown/failed: 5/0/0" cmd=agent sub=aggr
time="2024-10-15T09:07:15Z" level=info msg="Report: Jobs: ok/unknown/failed: 7/0/0" cmd=agent sub=aggr
time="2024-10-15T09:07:15Z" level=info msg="Report: SourceHost: ok/unknown/failed: 1/0/0" cmd=agent sub=aggr
time="2024-10-15T09:07:15Z" level=info msg="Report: DestHost: ok/unknown/failed: 5/0/0" cmd=agent sub=aggr
time="2024-10-15T09:08:16Z" level=info msg="Report: Jobs: ok/unknown/failed: 7/0/0" cmd=agent sub=aggr
time="2024-10-15T09:08:16Z" level=info msg="Report: SourceHost: ok/unknown/failed: 1/0/0" cmd=agent sub=aggr
time="2024-10-15T09:08:16Z" level=info msg="Report: DestHost: ok/unknown/failed: 5/0/0" cmd=agent sub=aggr
time="2024-10-15T09:09:16Z" level=info msg="Report: Jobs: ok/unknown/failed: 7/0/0" cmd=agent sub=aggr
time="2024-10-15T09:09:16Z" level=info msg="Report: SourceHost: ok/unknown/failed: 1/0/0" cmd=agent sub=aggr
time="2024-10-15T09:09:16Z" level=info msg="Report: DestHost: ok/unknown/failed: 5/0/0" cmd=agent sub=aggr
time="2024-10-15T09:10:17Z" level=info msg="Report: Jobs: ok/unknown/failed: 7/0/0" cmd=agent sub=aggr
time="2024-10-15T09:10:17Z" level=info msg="Report: SourceHost: ok/unknown/failed: 1/0/0" cmd=agent sub=aggr
time="2024-10-15T09:10:17Z" level=info msg="Report: DestHost: ok/unknown/failed: 5/0/0" cmd=agent sub=aggr
time="2024-10-15T09:11:18Z" level=info msg="Report: Jobs: ok/unknown/failed: 7/0/0" cmd=agent sub=aggr
time="2024-10-15T09:11:18Z" level=info msg="Report: SourceHost: ok/unknown/failed: 1/0/0" cmd=agent sub=aggr
time="2024-10-15T09:11:18Z" level=info msg="Report: DestHost: ok/unknown/failed: 5/0/0" cmd=agent sub=aggr

Release note:

Support tcp checks for ipv6 endpoints.

@DockToFuture DockToFuture requested a review from a team as a code owner October 15, 2024 09:09
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 15, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 15, 2024
ScheererJ
ScheererJ reviewed Oct 15, 2024
View reviewed changes
pkg/agent/runners/utils.go Outdated Show resolved Hide resolved
pkg/agent/runners/checktcpport.go Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 15, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 15, 2024
@DockToFuture DockToFuture added the area/ipcei IPCEI (Important Project of Common European Interest) label Oct 15, 2024
ScheererJ
ScheererJ approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 15, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 15, 2024
@MartinWeindel MartinWeindel merged commit b074f5c into gardener:main Oct 15, 2024
6 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DockToFuture @ScheererJ @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot