Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hashicorp/terraform-provider-aws #108

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Update hashicorp/terraform-provider-aws #108

merged 1 commit into from
Nov 23, 2021

Conversation

ialidzhikov
Copy link
Member

/area quality
/kind enhancement

This PR adopts fixes for hashicorp/terraform-provider-aws#21830 and hashicorp/terraform-provider-aws#21621.

With the new version of terraform-provider-aws I locally successfully validated the following scenarios for the provider:

  • reconciliation of existing Infrastructure
  • deletion of existing Infrastructure
  • creation and deletion of new Infrastructure (single zone, new vpc)
  • creation and deletion of new Infrastructure (multiple zones, new vpc)
  • creation and deletion of new Infrastructure (single zone, existing vpc)
  • creation and deletion of new Infrastructure (multiple zone, existing vpc)
  • gardener-extension-provider-aws Infrastructure integration test

Release note:

The following terraform provider plugins are updated:
- hashicorp/terraform-provider-aws: 3.63.0 -> 3.66.0

@ialidzhikov
Update hashicorp/terraform-provider-aws
d77fc52 
from 3.63.0 to 3.66.0

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested a review from a team as a code owner November 19, 2021 15:36
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 19, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 19, 2021
This was referenced Nov 19, 2021
Merged
Merged
@ialidzhikov
Copy link
Member Author

/invite @dkistner @kon-angelo @rfranzke

rfranzke
rfranzke approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 23, 2021
@kon-angelo
Copy link
Contributor

/lgtm

@ialidzhikov ialidzhikov merged commit 6696e4c into gardener:master Nov 23, 2021
@ialidzhikov ialidzhikov deleted the terraform-provider-aws branch November 23, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@dkistner dkistner Awaiting requested review from dkistner

@kon-angelo kon-angelo Awaiting requested review from kon-angelo

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ialidzhikov @kon-angelo @rfranzke @gardener-robot-ci-2 @gardener-robot