-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go v1.19 #129
Go v1.19 #129
Conversation
@kon-angelo Labels area/todo, kind/todo, priority/normal do not exist. |
/hold |
320fd56
to
9b749b9
Compare
/reviewed ok-to-test |
9b749b9
to
f46b8a7
Compare
f46b8a7
to
e204752
Compare
/reviewed ok-to-test |
ba47eeb
to
b0d39d8
Compare
7bf31fc
to
5401a60
Compare
/hold I need to test new images before proceeding |
@kon-angelo Label priority/normal does not exist. |
What's the status of this PR? |
The PR should be ready for review. I will update the golang version and will unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to use 1.19.5 in the meantime
Dockerfile
Outdated
@@ -3,7 +3,7 @@ | |||
# SPDX-License-Identifier: Apache-2.0 | |||
|
|||
############# golang-base | |||
FROM golang:1.16.15 AS golang-base | |||
FROM golang:1.19.3 AS golang-base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the latest 1.19 version
FROM golang:1.19.3 AS golang-base | |
FROM golang:1.19.5 AS golang-base |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@kon-angelo Label priority/normal does not exist. |
How to categorize this PR?
/area control-plane
/kind enhancement
/priority normal
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: