Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch GCR -> Artifact-Registry #143

Merged
merged 4 commits into from
Dec 8, 2023
Merged

switch GCR -> Artifact-Registry #143

merged 4 commits into from
Dec 8, 2023

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Dec 5, 2023

GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

  • europe-docker.pkg.dev/gardener-project/snapshots for snapshots
  • europe-docker.pkg.dev/gardener-project/releases for releases
  • europe-docker.pkg.dev/gardener-project/public for combined view of snapshots + releases

In addition, switch testmachinery-Image to new location in Artifact-Registry.

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr

Release note:

Change OCI Image Registry from GCR (`eu.gcr.io/gardener-project`) to Artifact-Registry (`europe-docker.pkg.dev/gardener-project/releases`). Users should update their references.

@ccwienk
cleanup: rm obsolete/redundant attributes
c8bbffe
@ccwienk
switch OCI-Builder from kaniko -> docker-buildx
2fea82c 
kaniko as OCI Builder is being phased-out in favour of docker-buildx.
@ccwienk
switch testmachinery-image to new location (Artifact-Registry)
51812cb
@ccwienk
switch GCR -> Artifact-Registry
ab840bd 
GCR has been deprecated [0] in favour of Artifact-Registry.

Thus, change push-targets for OCI-Images:

- europe-docker.pkg.dev/gardener-project/snapshots for snapshots
- europe-docker.pkg.dev/gardener-project/releases for releases
- europe-docker.pkg.dev/gardener-project/public for read-access to
  snapshots + releases

[0]
https://cloud.google.com/artifact-registry/docs/transition/transition-from-gcr
@ccwienk ccwienk requested a review from a team as a code owner December 5, 2023 19:26
@gardener-robot gardener-robot added the needs/review Needs review label Dec 5, 2023
@ccwienk ccwienk requested a review from hendrikKahl December 5, 2023 19:26
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Dec 5, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 5, 2023
@ccwienk ccwienk requested a review from kon-angelo December 5, 2023 19:27
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 5, 2023
kon-angelo
kon-angelo approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 8, 2023
@ccwienk ccwienk merged commit 63ab708 into master Dec 8, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 8, 2023
@ccwienk ccwienk deleted the gcr-to-ar branch December 8, 2023 13:30
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 8, 2023
@hendrikKahl hendrikKahl mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@hendrikKahl hendrikKahl Awaiting requested review from hendrikKahl

@aaronfern aaronfern Awaiting requested review from aaronfern

@MartinWeindel MartinWeindel Awaiting requested review from MartinWeindel

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccwienk @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot