Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEP-26] Update azurerm provider to 3.47.0 #156

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

dimityrmirchev
Copy link
Member

@dimityrmirchev dimityrmirchev commented Oct 30, 2024

How to categorize this PR?

/area usability
/kind bug

What this PR does / why we need it:
This PR updates the azurerm provider to version 3.47.0. A bug which prevents the OIDC_TOKEN_FILE_PATH to be read was introduced in 3.44.0 and fixed in 3.47.0. See hashicorp/terraform-provider-azurerm#20671 for more details.

I have tested creating and deleting a shoot cluster using the local Gardener with extensions setup.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Part gardener/gardener#9586

Release note:

Provider `azurerm` was updated to version 3.47.0 and is now properly recognising the `ARM_OIDC_TOKEN_FILE_PATH` env variable.

@gardener-robot
Copy link

@dimityrmirchev Labels area/todo, kind/todo do not exist.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 30, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 30, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 30, 2024
@@ -5,7 +5,7 @@
terraform {
required_providers {
azurerm = {
version = "3.44.0"
version = "3.47.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also bump the version in

azurerm = {
version = "3.44.0"
}
?

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 31, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 31, 2024
@dimityrmirchev dimityrmirchev marked this pull request as ready for review October 31, 2024 09:38
@dimityrmirchev dimityrmirchev requested review from a team as code owners October 31, 2024 09:38
@gardener-robot gardener-robot added the area/usability Usability related label Oct 31, 2024
@dimityrmirchev dimityrmirchev requested a review from a team as a code owner October 31, 2024 09:38
@dimityrmirchev dimityrmirchev requested review from a team as code owners October 31, 2024 09:38
@dimityrmirchev
Copy link
Member Author

/area ipcei

@gardener-robot gardener-robot added the area/ipcei IPCEI (Important Project of Common European Interest) label Oct 31, 2024
@dimityrmirchev
Copy link
Member Author

cc @vpnachev

Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 18, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 18, 2024
@vpnachev
Copy link
Member

vpnachev commented Jan 8, 2025

Kindly pinging maintainers for a code review.

Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit 997bd6c into gardener:master Jan 10, 2025
12 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipcei IPCEI (Important Project of Common European Interest) area/usability Usability related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants