Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update alicloud tf provider version #45

Merged
merged 1 commit into from
Sep 1, 2020
Merged

update alicloud tf provider version #45

merged 1 commit into from
Sep 1, 2020

Conversation

minchaow
Copy link
Contributor

@minchaow minchaow commented Aug 31, 2020 •
edited by ialidzhikov
Loading

What this PR does / why we need it:
This PR is to update alicloud provider version. Current provider has one issue which will cause the following error when creating infrastructure of shoot.

  • provider.alicloud: version = "~> 1.84"
  • provider.null: version = "~> 2.1"

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.
null_resource.outputs: Creating...
null_resource.outputs: Creation complete after 0s [id=7713401392548408619]
alicloud_vpc.vpc: Creating...
alicloud_eip.eip_natgw_z0: Creating...
alicloud_key_pair.publickey: Creating...
alicloud_key_pair.publickey: Creation complete after 2s [id=provider-alicloud-test-xw9pn-ssh-publickey]
alicloud_vpc.vpc: Creation complete after 6s [id=vpc-gw8s7kk5r0dj627fs079a]
alicloud_security_group.sg: Creating...
alicloud_nat_gateway.nat_gateway: Creating...
alicloud_vswitch.vsw_z0: Creating...
alicloud_eip.eip_natgw_z0: Creation complete after 6s [id=eip-gw867k5zsbhhonh5rzebs]
alicloud_security_group.sg: Creation complete after 1s [id=sg-gw8ca61r8km4ri36lkqk]
alicloud_security_group_rule.allow_all_internal_udp_in: Creating...
alicloud_security_group_rule.allow_all_internal_tcp_in: Creating...
alicloud_security_group_rule.allow_all_internal_tcp_in: Creation complete after 1s [id=sg-gw8ca61r8km4ri36lkqk:ingress:tcp:1/65535::10.250.0.0/16: accept:1]
alicloud_security_group_rule.allow_k8s_tcp_in: Creating...
alicloud_security_group_rule.allow_all_internal_udp_in: Creation complete after 1s [id=sg-gw8ca61r8km4ri36lkqk:ingress:udp:1/65535::10.250.0.0/16: accept:1]
alicloud_security_group_rule.allow_k8s_tcp_in: Creation complete after 1s [id=sg-gw8ca61r8km4ri36lkqk:ingress:tcp:30000/32767::0.0.0.0/0: accept:1]
alicloud_vswitch.vsw_z0: Creation complete after 4s [id=vsw-gw8ws2v1zxt18k2zw2lln]
alicloud_nat_gateway.nat_gateway: Still creating... [10s elapsed]
alicloud_nat_gateway.nat_gateway: Still creating... [20s elapsed]
alicloud_nat_gateway.nat_gateway: Still creating... [30s elapsed]

Error: rpc error: code = Internal desc = grpc: error while marshaling: proto: field "tfplugin5.Diagnostic.Summary" contains invalid UTF-8

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`terraform-provider-alicloud` is now updated to `1.94.0`.

@minchaow minchaow requested a review from a team as a code owner August 31, 2020 06:30
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 31, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 31, 2020
@ialidzhikov
Copy link
Member

The build seems to be failing.

/status author-action

@gardener-robot gardener-robot added the status/author-action Issue requires issue author action label Aug 31, 2020
@gardener-robot
Copy link

@minchaow The pull request was assigned to you under author-action. Please unassign yourself when you are done. Thank you.

@minchaow
Copy link
Contributor Author

@ialidzhikov: I have no permission to see the details of CI error, could you please share me the error info?

@ialidzhikov
Copy link
Member

ialidzhikov commented Aug 31, 2020 •
edited
Loading

@ialidzhikov: I have no permission to see the details of CI error, could you please share me the error info?

Log in if you are not, and make sure you are a member in the gardener org the core team.

@minchaow minchaow mentioned this pull request Aug 31, 2020
Merged
@ialidzhikov
Copy link
Member

ialidzhikov commented Aug 31, 2020 •
edited
Loading

Do you have a reference to an upstream issue/bug that you are trying to adopt with this PR?

I see that starting from v1.92.0 provider-alicloud changed their release artifact and it does now contain not only the provider plugin binary but also README.md, CHANGELOG.md and LICENSE files, that's why the publish job fails.

@ialidzhikov ialidzhikov mentioned this pull request Aug 31, 2020
Merged
@minchaow
Copy link
Contributor Author

minchaow commented Sep 1, 2020

Do you have a reference to an upstream issue/bug that you are trying to adopt with this PR?

No, I think the problem is caused by enhanced NAT of alicloud resources. Because the new resource is only supported in Europe region, and its usage is not large, so the problem is not exposed.

Contacted with Alicloud staff, and was told to have a try with the latest version of TF provider. The problem doesn't occur with the latest version.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 1, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 1, 2020
ialidzhikov
ialidzhikov approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed status/author-action Issue requires issue author action labels Sep 1, 2020
@ialidzhikov ialidzhikov merged commit 1fae930 into gardener:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees

@minchaow minchaow

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@minchaow @ialidzhikov @gardener-robot @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3