Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this PR, the destroy logic and testing was executed as part of a cleanup action. This is a bit dirty, as the destroy logic is part of the actual test and not just cleanup.
Also, this could lead to resource leakage on AWS and on the test-machinery cluster, because if one cleanup action fails (e.g. the destroy logic) no further cleanup actions are executed.
Now, the destroy logic is executed as a deferred function to ensure that the cleanup actions are still run, even if the test itself fails.
Additionally, a real cleanup action is added, that cleans up AWS resources left over from the test via the aws go sdk, so we can avoid manual cleanup on test failures.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
@schrodit, thanks for your help and input!
Release note: