-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add finalizer to the user secret and configmaps #65
Conversation
/test |
Testrun: e2e-5j2f4 +--------------+--------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +--------------+--------------+-----------+----------+ | pod-e2e-test | pod-e2e-test | Succeeded | 2m27s | +--------------+--------------+-----------+----------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some first feedback inline.
I still have to go through the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final minor remarks.
/test |
Testrun: e2e-vs8q5 +--------------+--------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +--------------+--------------+-----------+----------+ | pod-e2e-test | pod-e2e-test | Succeeded | 2m41s | +--------------+--------------+-----------+----------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last minor comment :)
Otherwise lgtm.
@vpnachev The pull request was assigned to you under |
/test |
Testrun: e2e-jrxxj +--------------+--------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +--------------+--------------+-----------+----------+ | pod-e2e-test | pod-e2e-test | Succeeded | 2m32s | +--------------+--------------+-----------+----------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you very much, @vpnachev!
/lgtm
How to categorize this PR?
/area quality
/area robustness
/kind enhancement
/priority normal
What this PR does / why we need it:
Ensures that the configmaps and secrets used by the terraformer have a finalizer as long as a successful destroy is executed.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: