Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area robustness ops-productivity
/kind bug
/priority normal
What this PR does / why we need it:
When terraformer is interrupted during terraform destroy execution (i.e. because of a timeout in the infrastructure actuator), it won't remove its finalizer from terraform resources (configmaps and secret), even if the terraform execution was successful and no infrastructure resources are left.
Leaking the finalizers will lead to manual ops effort as it will block the shoot's namespace in the seed to be stuck in termination.
Special notes for your reviewer:
Should be cherry-picked to
release-v2.1
.Release note: