-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch packet to equinix metal #73
Conversation
@deitch Thank you for your contribution. |
Thank you @deitch for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
de51421
to
73c3236
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
73c3236
to
af20f5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Shouldn't build/equinixmetal/TF_VERSION
be bumped to v0.13.x
now or am I missing something?
I thought I did. Huh. OK, repushing. |
Signed-off-by: Avi Deitcher <avi@deitcher.net>
af20f5e
to
d90be6b
Compare
Ah, it is a symlink! Ok, broke the link and gave it a specific version. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, much easier now with the provider-specific tf version :)
Thank you!
/lgtm
/ok-to-test
@@ -42,12 +42,12 @@ terraformer: | |||
target: terraformer | |||
build_args: | |||
PROVIDER: openstack | |||
terraformer-packet: | |||
terraformer-equinixmetal: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: the build for this PR will probably fail now because of the renaming, as the pipeline configs on the source branch are not considered for overwriting config on the base branch.
We will merge it nevertheless, on master it should build then.
Hmm, the build on master actually didn't work: https://concourse.ci.gardener.cloud/teams/gardener/pipelines/terraformer-master/jobs/master-head-update-job/builds/21#L602fba49:182 |
@timebertt wrote:
I cannot see that, get a 401. Can you paste some of the output here?
I did. It ran fine to the end, created the image and exited 0. I can run the image without issue. |
😞 Opened #75 for now. |
Anyways, the output was containing this:
I think, #76 should fix it :) |
Signed-off-by: Avi Deitcher avi@deitcher.net
How to categorize this PR?
/area control-plane
/kind enhancement
/priority normal
What this PR does / why we need it:
pre-bundle.sh
option, so that can pre-download if needed.Special notes for your reviewer:
Release note: