-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create image without pre-installed tf plugins #77
create image without pre-installed tf plugins #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have to extend https://github.com/gardener/terraformer/blob/master/.ci/pipeline_definitions#L10-L50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure about the naming, rest lgtm
/squash |
@timebertt I renamed the image to |
Yes, please rename it everywhere consistently to avoid confusion.
I've already added the |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Image build fails: https://concourse.ci.gardener.cloud/teams/gardener/pipelines/terraformer-master/jobs/master-head-update-job/builds/23#L603545bb:206:209
@Diaphteiros can you please fix it and check that it works locally using |
@timebertt I just tried it locally, but |
Ah, it's the publish step that fails. Will check that. |
How to categorize this PR?
/kind enhancement
/priority normal
What this PR does / why we need it:
As discussed in #74, we would like a terraformer image without any pre-installed terraform plugins.
Which issue(s) this PR fixes:
Fixes #74
Special notes for your reviewer:
Not sure whether
terraformer-none
orterraformer-empty
is the more intuitive name here. WDYT?Release note: