Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create image without pre-installed tf plugins #77

Merged
merged 3 commits into from
Feb 23, 2021
Merged

create image without pre-installed tf plugins #77

merged 3 commits into from
Feb 23, 2021

Conversation

Diaphteiros
Copy link
Contributor

How to categorize this PR?

/kind enhancement
/priority normal

What this PR does / why we need it:
As discussed in #74, we would like a terraformer image without any pre-installed terraform plugins.

Which issue(s) this PR fixes:
Fixes #74

Special notes for your reviewer:
Not sure whether terraformer-none or terraformer-empty is the more intuitive name here. WDYT?

Release note:

Terraformer will now publish an additional image without any pre-installed terraform plugins.

@Diaphteiros Diaphteiros requested a review from a team as a code owner February 22, 2021 12:03
@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension priority/normal needs/rebase Needs git rebase needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 22, 2021
@Diaphteiros
Copy link
Contributor Author

cc @schrodit @timebertt

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 22, 2021
@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Feb 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2021
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build/none/TF_VERSION Outdated Show resolved Hide resolved
build/none/terraform-bundle.hcl Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2021
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about the naming, rest lgtm

.ci/pipeline_definitions Outdated Show resolved Hide resolved
@timebertt
Copy link
Member

/squash

@gardener-robot gardener-robot added the merge/squash Should be merged via 'Squash and merge' label Feb 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 22, 2021
@Diaphteiros
Copy link
Contributor Author

@timebertt I renamed the image to terraformer-slim, but I kept the none in the Makefile - is this ok or should I rename it there too?
Should I squash this PR into one commit or will you do it during merging?

@timebertt
Copy link
Member

Yes, please rename it everywhere consistently to avoid confusion.

Should I squash this PR into one commit or will you do it during merging?

I've already added the merge/squash label which indicates that the person merging the PR should use the "Squash and Merge" option.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2021
@Diaphteiros
Copy link
Contributor Author

Yes, please rename it everywhere consistently to avoid confusion.

Done.

@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 23, 2021
.ci/pipeline_definitions Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Feb 23, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 23, 2021
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Feb 23, 2021
@timebertt timebertt merged commit 681f1d2 into gardener:master Feb 23, 2021
@timebertt
Copy link
Member

Image build fails: https://concourse.ci.gardener.cloud/teams/gardener/pipelines/terraformer-master/jobs/master-head-update-job/builds/23#L603545bb:206:209

Step 22/24 : COPY --from=terraform-base /tmp/terraformer/terraform /bin/terraform
 ---> f40151d11bff
Step 23/24 : COPY --from=terraform-base /tmp/terraformer/terraform-provider* /terraform-providers/
COPY failed: no source files were specified

@Diaphteiros can you please fix it and check that it works locally using docker build (buildkit seems to not fail builds if COPY has no source files)?

@Diaphteiros
Copy link
Contributor Author

@timebertt I just tried it locally, but make docker-images as well as docker build both run through without any problems on my system. I will have a look at the pipeline.

@Diaphteiros
Copy link
Contributor Author

Ah, it's the publish step that fails. Will check that.

@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable dynamic loading of terraform plugins
7 participants