Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable kaniko and update golang to 1.16.2 #85

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Enable kaniko and update golang to 1.16.2 #85

merged 1 commit into from
Mar 30, 2021

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Mar 21, 2021 •
edited by ialidzhikov
Loading

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:

  • Upgrades golang to 1.16.2
  • Upgrades alpine to 3.13.2
  • Enables the kaniko image build for the OCI images.

Which issue(s) this PR fixes:
Follow up on #82 as golang/go#43985 has been fixed in golang 1.16.1

Special notes for your reviewer:

Release note:

The golang has been updated to `1.16.2`, the alpine has been updated to `3.13.2`.

@vpnachev vpnachev requested a review from a team as a code owner March 21, 2021 10:12
@gardener-robot gardener-robot added the needs/review Needs review label Mar 21, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2021
@gardener-robot
Copy link

@vpnachev Label priority/normal does not exist.

@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 21, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 21, 2021
ialidzhikov
ialidzhikov approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 21, 2021
@vpnachev
Copy link
Member Author

The verify job is failing because it is still using golang 1.15, I think we will need to merge this without successful checks.

timebertt
timebertt approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke for "force-merge".

@vpnachev
Copy link
Member Author

A friendly ping to @rfranzke.

@rfranzke
Copy link
Member

Sorry for the delay

@rfranzke rfranzke merged commit 6fc87de into gardener:master Mar 30, 2021
@vpnachev vpnachev deleted the golang-n-kaniko branch March 30, 2021 06:47
@vpnachev vpnachev mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt approved these changes

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vpnachev @gardener-robot @rfranzke @ialidzhikov @timebertt @gardener-robot-ci-1