Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update hashicorp/terraform-provider-aws" #87

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Mar 29, 2021

This reverts commit 320ca1e.

How to categorize this PR?

/area ops-productivity
/kind regression

What this PR does / why we need it:
Downgrade AWS provider to 3.18.0.
The newer version require additional permissions, e.g. iam:ListRolePolicies.
but we need time to announce such change in advance and request users to
update their policies accordingly.

Which issue(s) this PR fixes:
Partially reverts #84
More info gardener/gardener-extension-provider-aws#301

Special notes for your reviewer:

Release note:

The aws provider has been downgraded from `3.32.0` to `3.18.0` due to issue with additionally required permission for the AWS accounts.

This reverts commit 320ca1e.

The newer version require additional permissions, e.g. iam:ListRolePolicies.
but we need time to announce such change in advance and request users to
update their policies accordingly.
@vpnachev vpnachev requested a review from a team as a code owner March 29, 2021 15:56
@gardener-robot gardener-robot added area/ops-productivity Operator productivity related (how to improve operations) kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution labels Mar 29, 2021
@gardener-robot
Copy link

@vpnachev Label priority/normal does not exist.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 29, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2021
@gardener-robot
Copy link

@vpnachev Label priority/normal does not exist.

@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 29, 2021
@gardener-robot
Copy link

@vpnachev Label priority/normal does not exist.

Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 29, 2021
@ialidzhikov ialidzhikov merged commit 4614760 into gardener:master Mar 29, 2021
@vpnachev vpnachev deleted the downgrade-aws branch March 29, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ops-productivity Operator productivity related (how to improve operations) kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants