Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade TF provider 1.124.2 #96

Merged
merged 1 commit into from
Jun 16, 2021
Merged

upgrade TF provider 1.124.2 #96

merged 1 commit into from
Jun 16, 2021

Conversation

minchaow
Copy link
Contributor

@minchaow minchaow commented Jun 15, 2021 •
edited by ialidzhikov
Loading

How to categorize this PR?

/area open-source
/kind bug

What this PR does / why we need it:
This PR is to fix the issue of failing to SNatTableEntries because of flow control.
Which issue(s) this PR fixes:
Fixes #
aliyun/terraform-provider-alicloud#3617
Special notes for your reviewer:

Release note:

The following terraform provider plugin is updated:
- aliyun/terraform-provider-alicloud: 1.124.0 -> 1.124.2

@minchaow minchaow requested a review from a team as a code owner June 15, 2021 03:09
@gardener-robot gardener-robot added the needs/review Needs review label Jun 15, 2021
@gardener-robot
Copy link

@minchaow Label priority/normal does not exist.

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/bug Bug size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 15, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 15, 2021
@gardener-robot
Copy link

@minchaow Label priority/normal does not exist.

@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 15, 2021
vpnachev
vpnachev reviewed Jun 15, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 1.124.2 is released. Do you want to upgrade to it?

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 15, 2021
@minchaow minchaow changed the title upgrade TF provider 1.124.1 upgrade TF provider 1.124.2 Jun 15, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 15, 2021
@minchaow
Copy link
Contributor Author

I see 1.124.2 is released. Do you want to upgrade to it?

Good suggestion, I updated the provider to 1.124.2

ialidzhikov
ialidzhikov approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 15, 2021
vpnachev
vpnachev approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

dkistner
dkistner approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ialidzhikov ialidzhikov merged commit ae8adcd into gardener:master Jun 16, 2021
@ialidzhikov ialidzhikov mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

@vpnachev vpnachev vpnachev approved these changes

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@minchaow @gardener-robot @dkistner @vpnachev @ialidzhikov @gardener-robot-ci-1 @gardener-robot-ci-2