Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm provider #99

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Conversation

dkistner
Copy link
Member

@dkistner dkistner commented Jul 20, 2021

How to categorize this PR?

/kind enhancement
/priority normal

What this PR does / why we need it:
Update azurerm provider from 2.36.0 to 2.68.0

Release note:

The terraform `azurerm` provider plugin is updated from `v2.36.0` to `v2.68.0`.
Once the `azurerm` provider plugin is updated from `v2.36.0` to `v2.68.0` the `skip_provider_registration` flag  in the `provider` section need to be set to `true`.

from 2.36.0 to 2.68.0
@dkistner dkistner requested a review from a team as a code owner July 20, 2021 10:16
@gardener-robot gardener-robot added the needs/review Needs review label Jul 20, 2021
@gardener-robot
Copy link

@dkistner Label priority/normal does not exist.

@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 20, 2021
@gardener-robot
Copy link

@dkistner Label priority/normal does not exist.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 20, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2021
@kon-angelo
Copy link
Contributor

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 20, 2021
@ialidzhikov
Copy link
Member

Can you confirm that locally you played with the following cases and they all worked well?

  • reconciliation of existing Infrastructure
  • deletion of existing Infrastructure
  • creation and deletion of new Infrastructure (zoned=false, new vnet)
  • creation and deletion of new Infrastructure (zoned=true, new vnet)
  • creation and deletion of new Infrastructure (zoned=false, existing vnet)

@kon-angelo
Copy link
Contributor

@ialidzhikov , I tested the scenarios and they work.

For the new version to work we need to make an adaptation to the provider section and add this skip_provider_registration = "true".

@ialidzhikov
Copy link
Member

@ialidzhikov , I tested the scenarios and they work.

Thanks!

Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ialidzhikov ialidzhikov merged commit aa3c6a0 into gardener:master Jul 21, 2021
@vpnachev
Copy link
Member

vpnachev commented Jul 21, 2021

For the new version to work we need to make an adaptation to the provider section and add this skip_provider_registration = "true".

Please, describe what needs to be done in a release note.

@dkistner dkistner deleted the update-azurerm branch July 21, 2021 19:18
@gardener-robot
Copy link

@dkistner Label priority/normal does not exist.

@ialidzhikov
Copy link
Member

ialidzhikov commented Aug 18, 2021

@ialidzhikov , I tested the scenarios and they work.

Out of curiosity, how the scenario deletion of existing Infrastructure worked for you as I see that it does not work for me - gardener/gardener-extension-provider-azure#359?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants