Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix loss of Status subresource information #421

Merged
merged 2 commits into from
Aug 29, 2022
Merged

fix loss of Status subresource information #421

merged 2 commits into from
Aug 29, 2022

Conversation

hendrikKahl
Copy link
Contributor

Signed-off-by: hendrikKahl hendrik.kahl@sap.com

How to categorize this PR?

/area testing
/kind bug

What this PR does / why we need it:
Fix a bug within the reconcile loop, where the code relied on the behavior fixed with this PR: kubernetes-sigs/controller-runtime#1640

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @acumino

Release note:

fix loss of `Status` subresource information

@hendrikKahl hendrikKahl requested a review from a team as a code owner August 26, 2022 09:30
@gardener-robot gardener-robot requested a review from acumino August 26, 2022 09:30
@gardener-robot gardener-robot added area/testing Testing related kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 26, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 26, 2022
@hendrikKahl
fix loss of Status subresource information
95001dd 
Signed-off-by: hendrikKahl <hendrik.kahl@sap.com>
@hendrikKahl hendrikKahl force-pushed the fix/reconcile-status branch from 9b83ae7 to 95001dd Compare August 26, 2022 09:43
@hendrikKahl hendrikKahl requested a review from acumino August 26, 2022 09:43
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 26, 2022
acumino
acumino approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 26, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 29, 2022
@hendrikKahl
Copy link
Contributor Author

all reviewers are unavailable for the next 2 weeks, however this fix is needed to progress some other stories.
Hence I'll go ahead and merge it anyways. 👻 It's been tested in our staging environment.

@hendrikKahl hendrikKahl merged commit 3495793 into gardener:master Aug 29, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 29, 2022
@hendrikKahl hendrikKahl deleted the fix/reconcile-status branch August 29, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acumino acumino acumino approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hendrikKahl @acumino @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot