Install Flag for Pre-Installed Diamond #18
Conversation
| @@ -80,6 +83,7 @@ | |||
| $handlers_path = undef, | |||
| $purge_collectors = false, | |||
| $install_from_pip = false, | |||
| $install = true, | |||
There was a problem hiding this comment.
I'd maybe name this something a bit more explicit, like manage_installation
|
Thanks for submitting this, and apologies for taking a while to get back to you. I'd be more than happy to see this included. Would you be able to add a simple rspec test to verify the functionality? Some details in the CONTRIBUTING file https://github.com/garethr/garethr-diamond/blob/master/CONTRIBUTING.md but I'm also happy to help with any questions. The tests help with making sure functionality doesn't get broken in future releases, especially with various people using the module and sending helpful pull requests like this one. |
|
I am interested in making these changes and running the tests, but due to work schedule I won't be able to do them for a couple of weeks. |
|
Thanks, and no problem on the timing. Let me know if I can help. |
|
Sure, thanks for the offer. |
|
The work became super hectic, and I don't think I can do the tests anytime soon. Just giving a heads up :) |
We are creating our OS images with every software products that we need are pre-installed. Then we use vagrant, which uses puppet to configure those software products. If we use the diamond package as is, we get duplicate declaration errors. That's why I introduced an install flag to skip the installation and just use the configuration. I think this change might be useful to other people as well.
Cheers,
Sercan Aktas