libkvs/lookup: lookup_get_raw use use void **

As discussed in flux-framework#1144, function result parameters like the one in flux_kvs_lookup_get_raw() should probably be void ** not void *.
garlick · Aug 8, 2017 · 73dc493 · 73dc493
1 parent ebfdb01
commit 73dc493
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/common/libkvs/kvs_lookup.c b/src/common/libkvs/kvs_lookup.c
@@ -252,7 +252,7 @@ int flux_kvs_lookup_get_unpack (flux_future_t *f, const char *fmt, ...)
     return rc;
 }
 
-int flux_kvs_lookup_get_raw (flux_future_t *f, void *data, int *len)
+int flux_kvs_lookup_get_raw (flux_future_t *f, void **data, int *len)
 {
     struct lookup_ctx *ctx;
 
@@ -271,7 +271,7 @@ int flux_kvs_lookup_get_raw (flux_future_t *f, void *data, int *len)
         ctx->val_valid = true;
     }
     if (data)
-        *(void **)data = ctx->val_data;
+        *data = ctx->val_data;
     if (len)
         *len = ctx->val_len;
     return 0;

diff --git a/src/common/libkvs/kvs_lookup.h b/src/common/libkvs/kvs_lookup.h
@@ -13,7 +13,7 @@ flux_future_t *flux_kvs_lookupat (flux_t *h, int flags, const char *key,
 
 int flux_kvs_lookup_get (flux_future_t *f, const char **json_str);
 int flux_kvs_lookup_get_unpack (flux_future_t *f, const char *fmt, ...);
-int flux_kvs_lookup_get_raw (flux_future_t *f, void *data, int *len);
+int flux_kvs_lookup_get_raw (flux_future_t *f, void **data, int *len);
 
 #endif /* !_FLUX_CORE_KVS_LOOKUP_H */