Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating and reviews are non-required fields #100

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Conversation

zetoke
Copy link
Contributor

@zetoke zetoke commented Oct 1, 2019

Rating and aggregated reviews are non-required fields (but recommended) according to Google documentations and looks like it also handled by codebase.
So I just tuned up a type for component props.

Sometimes you can have a product on your website but you can have no reviews or ratings for products.

image

https://developers.google.com/search/docs/data-types/product

@garmeeh
Copy link
Owner

garmeeh commented Oct 4, 2019

@all-contributors please add @zetoke for code

@allcontributors
Copy link
Contributor

@garmeeh

I've put up a pull request to add @zetoke! 🎉

Copy link
Owner

@garmeeh garmeeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, thanks for that. 😄

@garmeeh garmeeh merged commit 985d43a into garmeeh:master Oct 4, 2019
@zetoke
Copy link
Contributor Author

zetoke commented Oct 4, 2019

@garmeeh Thank you for your efforts and maintaining the package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants