[opam] [dune-release] Fix opam metadata to reflect recent release. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
lablgtk3+opam_tweaks
branch
5 times, most recently
from
c930dfe to
0351116
Compare
|
Any idea why the MacOS test fails? |
Bug ocaml/dune#1833 makes our quoting strategy fail; unfortunately it is not easy to fix due to OS-specific issues. IMHO the issue is not so serious as to warrant an ugly workaround, thus we rather declare a conflict with Dune 1.7.0.
ejgallego
force-pushed
the
lablgtk3+opam_tweaks
branch
2 times, most recently
from
cfffc0f to
aa447ac
Compare
|
CI is good here too [note this PR includes #49 ] |
After 3.0.beta4, the loose constraints should mostly work; depending on the changes we do of course. We also update the `homepage` field of the OPAM files, and the CHANGES file, if I understand correctly this should indeed make `dune-release` work out of the box [and to produce sensible changelogs] Note that dune-release was incorrectly reading `CHANGES.API` to create the OPAM changelog! So I had to fix that too.
ejgallego
force-pushed
the
lablgtk3+opam_tweaks
branch
from
aa447ac to
ab0025d
Compare
|
This still fails on MacOS. Of course it works on my machine, but I'm using macports, not brew. |
|
This is a known bug in dune + brew @garrigue , nothing we can do here until they fix it upstream. See the dune issue tracker if you need more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 3.0.beta4, the loose constraints should mostly work; depending
on the changes we do of course.
We also update the
homepagefield of the OPAM files, and the CHANGESfile, if I understand correctly this should indeed make
dune-releasework out of the box [and to produce sensible changelogs]
Note that dune-release was incorrectly reading
CHANGES.APIto createthe OPAM changelog! So I had to fix that too.