Starting port from configuration (#613)

Looks good. Thanks.
garris · Dec 10, 2017 · fa28f51 · fa28f51
1 parent 79cbbf5
commit fa28f51
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -514,7 +514,7 @@ See casperjs documentation for more info on instance options.  An example config
 Chromy enables a lot of behavior via constructor options.  See Chromy documentation for more info.
 
 **NOTE:** Backstop sets defaults for many Chromy properties. Setting a parameter value with engineOptions will override any default value set by backstop. _But please watch out for the following..._
-- (TLDR) Setting `port` is _very_ _very_ not advised.
+- (TLDR) Setting `port` is _very_ _very_ not advised. But you can change starting port in configuration. `"startingPort": 9333`
 - Setting `chromeFlags` will override all chromeFlags properties set by backstop -- **EXCEPT FOR `--window-size`***...  (i.e. `--window-size` flag will be added by backstop if not found in chromeFlags)
 - Setting `--window-size` explicitly in `chromeFlags` will override values used in your viewport settings.
 

diff --git a/core/util/runChromy.js b/core/util/runChromy.js
@@ -59,7 +59,7 @@ function processScenarioView (scenario, variantOrScenarioLabelSafe, scenarioLabe
   const VP_H = viewport.height || viewport.viewport.height;
 
   const DEFAULT_CHROME_FLAGS = ['--disable-gpu', '--force-device-scale-factor=1', '--disable-infobars=true'];
-  const PORT = CHROMY_STARTING_PORT_NUMBER + runId;
+  const PORT = (config.startingPort || CHROMY_STARTING_PORT_NUMBER) + runId;
   let defaultOptions = {
     chromeFlags: undefined,
     port: PORT,