Fix race condition in puppeteer readyEvent #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garris
reviewed
Apr 17, 2018
| if (readyEvent) { | ||
| await page.evaluate(`window._readyEvent = '${readyEvent}'`) | ||
| await page.evaluate(`window._readyEvent = '${readyEvent}'`); |
There was a problem hiding this comment.
I guess we are just adding this to ensure any existing dependencies are supported? We probably don't need this.
As a bonus I think it would also be nice to only enable the backstopTools log tracking if the engine is set to chromy. Not necessary to implement that bit though.
There was a problem hiding this comment.
Yeah I wasn't sure why it was there in the first place, if it's not necessary they by all means delete.
I believe the PR does as you say - since I only changed puppet, the chromy path is now the only path using backstopTools.
garris
approved these changes
Apr 17, 2018
|
This is a very nice improvement. This was overlooked when we migrated from chromy to puppeteer. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #739