-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Jenkins Guide #790
[Docs] Jenkins Guide #790
Conversation
Hi @Kenith, this looks good — but maybe this belongs in the examples directory — instead of under |
Hello @garris, we suggest to put it in Also, I have added .dockerignore to make sure the Jenkins folder won't be added to docker image. You are very welcome if you have any questions. Thank you, |
I am not sure that users will think the same way. A Jenkins user may actually expect to see the Docker config inside a top-level Jenkins directory (e.g. But maybe more important, this Jenkins/DooD approach is a (very useful but) very opinionated implementation -- which seems to be very good as an example but perhaps not ready for production use because of the security concerns (e.g. giving Jenkins sudo permissions and docker-outside-of-docker) -- whereas the existing Docker implementation is intended for general use and therefore given 1st class status inside the repo. I think this implementation serves as an excellent example -- it could probably be a very useful blog post as well. I would gladly highlight this in the documentation -- I think it would be very very appreciated by Jenkins users. |
Hello @garris, Really apologies for delay. These days are lots of drama things. I have moved the jenkins guide to examples. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thank you!
Add Jenkins Guide into docker/Jenkins