Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Jenkins Guide #790

Merged
merged 11 commits into from
Jun 7, 2018
Merged

[Docs] Jenkins Guide #790

merged 11 commits into from
Jun 7, 2018

Conversation

Kenith
Copy link
Contributor

@Kenith Kenith commented Jun 3, 2018

Add Jenkins Guide into docker/Jenkins

@garris
Copy link
Owner

garris commented Jun 3, 2018

Hi @Kenith, this looks good — but maybe this belongs in the examples directory — instead of under ./docker/?

@Kenith
Copy link
Contributor Author

Kenith commented Jun 4, 2018

Hello @garris, we suggest to put it in ./docker/, since the jenkins guide is based on the docker image backstopjs/backstopjs:latest.

Also, I have added .dockerignore to make sure the Jenkins folder won't be added to docker image.

You are very welcome if you have any questions.

Thank you,
Ken

@garris
Copy link
Owner

garris commented Jun 5, 2018

I am not sure that users will think the same way. A Jenkins user may actually expect to see the Docker config inside a top-level Jenkins directory (e.g. ./jenkins/docker/ or even ./jenkins-docker/).

But maybe more important, this Jenkins/DooD approach is a (very useful but) very opinionated implementation -- which seems to be very good as an example but perhaps not ready for production use because of the security concerns (e.g. giving Jenkins sudo permissions and docker-outside-of-docker) -- whereas the existing Docker implementation is intended for general use and therefore given 1st class status inside the repo.

I think this implementation serves as an excellent example -- it could probably be a very useful blog post as well. I would gladly highlight this in the documentation -- I think it would be very very appreciated by Jenkins users.

@Kenith
Copy link
Contributor Author

Kenith commented Jun 7, 2018

Hello @garris,

Really apologies for delay. These days are lots of drama things.

I have moved the jenkins guide to examples.
And I fully agree with your opinions about the security issue. In the coming days, I will seek help from our dev ops team for more professional jenkins settings.

Cheers,
Ken

Copy link
Owner

@garris garris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you!

@garris garris merged commit c5b0749 into garris:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants